894367 - Http.jsm mishandles empty / null postData

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Richard Marti (:Paenglab)]

Since 20130714 Daily shows the authentication window for Twitter. After entering the correct password the authentication reappears.

In console I get:

Tue Jul 16 2013 14:20:26
Error: 401 - {"errors":[{"message":"Could not authenticate you","code":32}]}
Source file: resource://gre/modules/Http.jsm
Line: 75
 ----------
Tue Jul 16 2013 14:20:26
Error: 401 - {"errors":[{"message":"Could not authenticate you","code":32}]}
Source file: resource://gre/components/twitter.js
Line: 593
Source code:
prpl-twitter

Last good version is 20130712

I suppose the issue has something to do with the http.jsm to toolkit bug 884319

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Log of my authentication attempt

This is a log of my authentication attempt with the keys removed.

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Fix v1

I slightly changed the behavior of checking for post data when switching Http.jsm to use an options object, we should only consider post data if the field is defined AND the field has data (i.e. is not null, undefined, empty, etc.) This matches the previous behavior.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 777505 [details] [diff] [review]
Fix v1

Review of attachment 777505 [details] [diff] [review]:
-----------------------------------------------------------------

Test please

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Test v1

Added a regression test.

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4f2677e2eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/28c8c52f1762

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c4f2677e2eb
https://hg.mozilla.org/mozilla-central/rev/28c8c52f1762